Skip to content

Add the logout callback to prevent exception. #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hcyuser wants to merge 1 commit into from
Closed

Add the logout callback to prevent exception. #1813

hcyuser wants to merge 1 commit into from

Conversation

@hcyuser
Copy link
Contributor

@hcyuser hcyuser commented Aug 9, 2023

No description provided.

hcyuser
hcyuser commented Aug 9, 2023
View reviewed changes
Copy link
Contributor Author

@hcyuser hcyuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add callback for logout

@hcyuser
Add the logout callback to prevent exception.
c6ea746 
Signed-off-by: hcyuser <user@hcy.idv.tw>
@hcyuser hcyuser force-pushed the bugfix/logout-exception branch from e95544b to c6ea746 Compare August 9, 2023 13:08
@jackycute
Copy link
Member

jackycute commented Aug 10, 2023

Hi @hcyuser,

Thanks for contribution.
Can you explain what is this PR solving?

@hcyuser
Copy link
Contributor Author

hcyuser commented Aug 10, 2023 •
edited
Loading

If we didn't add a callback in req.logout(callback),
It would get Error: req#logout requires a callback function on the webpage when running node app.js and clicking Sign out on the webpage.

@jackycute
Copy link
Member

jackycute commented Aug 10, 2023

Thanks for adding this.
This is caused by https://stackoverflow.com/questions/72336177/error-reqlogout-requires-a-callback-function from jaredhanson/passport#902 (comment)

jackycute
jackycute reviewed Aug 10, 2023
View reviewed changes
@hcyuser hcyuser force-pushed the bugfix/logout-exception branch from 2edf9c9 to c6ea746 Compare August 10, 2023 13:19
@Yukaii
Copy link
Member

Yukaii commented Dec 26, 2023

closed in favor of #1837

@Yukaii Yukaii closed this Dec 26, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackycute jackycute jackycute left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hcyuser @jackycute @Yukaii