fix: allTypes should look in imports#327
Merged
mergify[bot] merged 1 commit intomainfrom Mar 21, 2022
Merged
Conversation
Also adds some tests that would have caught this oversight. Note that the Eval one is only for consistency -- it would not have caught the bug since Eval does not ever look at type definitions.
brprice
commented
Mar 21, 2022
brprice
commented
Mar 21, 2022
Contributor
Author
|
Thanks @georgefst for pointing this bug out in #293 (review) |
georgefst
approved these changes
Mar 21, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a mistake in the initial implementation. The
documentation was correct, that it should look inside imports,
and the implementation was wrong.
Also adds some tests that would have caught this oversight.
Note that the Eval one is only for consistency -- it would not have
caught the bug since Eval does not ever look at type definitions.