merge-queue: embarking main (822e3b4) and #367 together#388
Closed
mergify[bot] wants to merge 19 commits intomainfrom
Closed
merge-queue: embarking main (822e3b4) and #367 together#388mergify[bot] wants to merge 19 commits intomainfrom
mergify[bot] wants to merge 19 commits intomainfrom
Conversation
As with `moduleDefs` (already a map), we often need to look up elements in it anyway. See, for example, all of the calls to `mkTypeDefMap` which previously existed in the `EvalFull` module (but not `Eval`, where we already required the caller to pass the definitions as a map).
Analogous to `unsafeGlobalName`. Very mildly simplifies some existing code, though we'll use it again shortly.
We ensure that the student's program continues to typecheck, by adding holes as necessary.
We can use `uniplate` instead, which also removes some boilerplate.
We include a regression test, which would have failed before this commit.
…f a typedef This is important in order to be consistent with `checkTypeDefs`.
Author
|
The pull request #367 is mergeable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (822e3b4) and #367 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #367.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base=maincheck-success="buildkite/primer/pr/required"More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com