merge-queue: embarking main (62017b0) and #375 together#408
Closed
mergify[bot] wants to merge 9 commits intomainfrom
Closed
merge-queue: embarking main (62017b0) and #375 together#408mergify[bot] wants to merge 9 commits intomainfrom
mergify[bot] wants to merge 9 commits intomainfrom
Conversation
This is in preperation for adding module names, which will require some renaming of primitives. We will export some identifiers for these names instead of writing them as literal strings, to make any future renames easier.
This is in preperation for adding module names, which will require some renaming of primitives.
This is not yet needed, as currently primitive types are always in scope -- the '...WithPrims' just adds primitive terms. But this will change shortly.
Instead of using 'defaultTypeDefs', define and use 'builtinModule' and 'primitiveModule'. This is in preparation for adding module names and taking modules more seriously. There is one theoretical drawback: in Tests.EvalFull we lose the ability to generate definitions for global variables. However, we never actually used this ability, so there is no loss in practice. (However, we may want to re-instate this ability in the future so we can generate an arbitrary context in these tests.)
This is a large commit, but most of it is pretty mechanical. NB: we remove the test 'unit_rename_def_capture'. It tested that we could not rename a definition in such a way that a reference would be captured by a local binding. However, now that global variables have module-qualified names, this is no longer possible: a local binding is not considered to shadow any globals. BREAKING CHANGE: this change requires a database migration, as it changes the representation of `Prog`. However, since this is just serialised to json and stored as a blob in the DB, it requires no schema changes. Since we have no programs we need to preserve, we decided not to bother with a migration. This means that DBs created before this commit will not load with a primer containing this commit.
Author
|
The pull request #375 is mergeable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (62017b0) and #375 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #375.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base=maincheck-success="buildkite/primer/pr/required"More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com