fix: RenameCon affects case branch labels#439
Merged
mergify[bot] merged 1 commit intomainfrom May 11, 2022
Merged
Conversation
Contributor
Author
brprice
commented
May 9, 2022
brprice
force-pushed
the
brprice/renamecon-case-branch
branch
2 times, most recently
from
f080c0e to
db70b29
Compare
When renaming a constructor 'C' to 'D', we must not only rename every
use of it as a constructor, but also where it appears as a branch label.
For example, in the code
case x of
C y -> (True, C 1)
there are two usages of 'C' to rename. Previously we only changed the
'C 1' and not the 'C y'.
brprice
force-pushed
the
brprice/renamecon-case-branch
branch
from
db70b29 to
7ee5a8b
Compare
georgefst
approved these changes
May 11, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When renaming a constructor
CtoD, we must not only rename everyuse of it as a constructor, but also where it appears as a branch label.
For example, in the code
there are two usages of
Cto rename. Previously we only changed theC 1and not theC y.