fix: AddConField, SetConFieldType robustness#441
Merged
mergify[bot] merged 2 commits intomainfrom May 11, 2022
Merged
Conversation
Contributor
Author
brprice
changed the title
brprice
force-pushed
the
brprice/AddConField-fixes
branch
2 times, most recently
from
e15f807 to
e42b7a0
Compare
brprice
force-pushed
the
brprice/renamecon-case-branch
branch
from
db70b29 to
7ee5a8b
Compare
There are two fixes here. Firstly, ensure that updating case branches is robust when the scrutinee is also updated (due to being an application of the given constructor). Secondly, handle the case of an application of a constructor of a parameterised type, i.e. where the spine includes type applications.
The fix for AddConField and parameterised types from the previous commit is also needed for SetConFieldType. (The other, about updating both a case scrutinee and a case branch, is not, since the modification to the scrutinee will not affect type inference.)
brprice
force-pushed
the
brprice/AddConField-fixes
branch
from
e42b7a0 to
4511478
Compare
georgefst
approved these changes
May 11, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two fixes here. Firstly, ensure that updating case branches is
robust when the scrutinee is also updated (due to being an application
of the given constructor). Secondly, handle the case of an application
of a constructor of a parameterised type, i.e. where the spine includes
type applications.