merge-queue: embarking main (02035e0) and #429 together#444
Closed
mergify[bot] wants to merge 7 commits intomainfrom
Closed
merge-queue: embarking main (02035e0) and #429 together#444mergify[bot] wants to merge 7 commits intomainfrom
mergify[bot] wants to merge 7 commits intomainfrom
Conversation
We consistently handle "not found" errors. This is in preparation for adding multiple editable modules. Thus we add some new errors `ModuleNotFound` and `ModuleReadonly` and use these as appropriate. Note that this may change some errors the API returns.
Currently they will return an error if they target anything other than the one editable module. However, we will shortly enable multiple editable modules, at which point we need to explicitly state what module they should affect. BREAKING CHANGE: this change requires a database migration, as it changes the representation of `Log`. However, since this is just serialised to json and stored as a blob in the DB, it requires no schema changes. Since we have no programs we need to preserve, we decided not to bother with a migration. This means that DBs created before this commit will not load with a primer containing this commit. This commit also changes Primer's API.
Previously we only viewed the contents of the one editable module. We now give the contents of every module, and also tag them with whether they are editable or imported. BREAKING CHANGE: this changes the response to an api endpoint, and this is reflected in the generated openapi schema.
NB: lots of this commit is fairly trivial testsuite churn BREAKING CHANGE: this change requires a database migration, as it changes the representation of `Prog`. However, since this is just serialised to json and stored as a blob in the DB, it requires no schema changes. Since we have no programs we need to preserve, we decided not to bother with a migration. This means that DBs created before this commit will not load with a primer containing this commit.
Author
|
The pull request #429 is mergeable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This combination of pull requests has been checked successfully 🎉
Branch main (02035e0) and #429 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #429.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue
defaultfor merge:base=maincheck-success="buildkite/primer/pr/required"More informations about Mergify merge queue can be found in the documentation.
Mergify commands
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the queue rulesAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com