Skip to content

chore(nix): Bump to haskell.nix experimental GHC 9.6 branch.#910

Closed
dhess wants to merge 11 commits intomainfrom
dhess/experimental
Closed

chore(nix): Bump to haskell.nix experimental GHC 9.6 branch.#910
dhess wants to merge 11 commits intomainfrom
dhess/experimental

Conversation

@dhess
Copy link
Copy Markdown
Member

@dhess dhess commented Mar 13, 2023

No description provided.

@dhess dhess force-pushed the dhess/experimental branch 10 times, most recently from c74585e to 95865dd Compare March 16, 2023 09:25
@dhess dhess force-pushed the dhess/experimental branch from ae0bcce to 3029d00 Compare March 18, 2023 03:28
@brprice
Copy link
Copy Markdown
Contributor

brprice commented Mar 20, 2023

I pushed a commit fixing logging-effect (using a unmerged upstream PR). We now seem to be hitting jfischoff/postgres-options#6 (which is odd -- it seems that the code on hackage is newer than that on github?)

@brprice
Copy link
Copy Markdown
Contributor

brprice commented Mar 20, 2023

There is also an interesting new warning in primer, which I minimized to: the following code warns:

{-# LANGUAGE DerivingStrategies #-}
{-# LANGUAGE GeneralizedNewtypeDeriving #-}
{-# OPTIONS -Wredundant-constraints #-}
module Primer.Database where

import Prelude
import Control.Monad.Reader
import Control.Applicative

newtype NullDbT m a = NullDbT {unNullDbT :: ReaderT Int m a}
  deriving newtype
    ( Functor
    , Applicative
    , Alternative
    , Monad
    , MonadTrans
    )
Bug.hs:16:7-16: warning: [GHC-30606] [-Wredundant-constraints]
    • Redundant constraint: Monad m
    • When deriving the instance for (MonadTrans NullDbT)
   |
16 |     , MonadTrans
   |       ^^^^^^^^^^

I have not yet worked out the issue This looks like a GHC bug to me. I have opened https://gitlab.haskell.org/ghc/ghc/-/issues/23143 upstream (this is fixed in ghc master, but not backported to 9.6.x yet).

@brprice
Copy link
Copy Markdown
Contributor

brprice commented Mar 27, 2023

I pushed a commit fixing logging-effect (using a unmerged upstream PR).

This is now fixed upstream, so when haskell.nix picks it up, we can replace that commit with one bumping logging-effect to 1.4.0

@brprice brprice mentioned this pull request Jul 4, 2023
@dhess
Copy link
Copy Markdown
Member Author

dhess commented Aug 16, 2023

Closing this as it's out of date: most of these workarounds are no longer necessary.

@dhess dhess closed this Aug 16, 2023
@dhess dhess deleted the dhess/experimental branch August 16, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants