Re-implement plyr::eval.quoted, plyr::as.quoted#112
Open
MichaelChirico wants to merge 1 commit intohadley:masterfrom
Open
Re-implement plyr::eval.quoted, plyr::as.quoted#112MichaelChirico wants to merge 1 commit intohadley:masterfrom
MichaelChirico wants to merge 1 commit intohadley:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with the others, it's not 100% clear there's a lot of value (besides maybe the new tests) in this PR at the moment. But since it's done, I'm sharing it anyway.
Written by Gemini.
This completes the series -- {plyr} is no longer required by package code.
It is still required by examples using
plyr::.. So that would technically mean moving {plyr} to Suggests without further work (e.g. to re-implement.as areshape2export). Eschewing that for now.reshape/man/cast.Rd
Lines 94 to 96 in 0337342
If you're keen to adopt any subset of these changes, I can help by putting them in a
jjstack that will facilitate merging without having to deal with so many merge conflicts among them. Let me know.