Skip to content

Release type "all" should use the "all" file instead of the "ga" file #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halcyon merged 1 commit into from
May 17, 2023
Merged

Release type "all" should use the "all" file instead of the "ga" file #198

halcyon merged 1 commit into from
May 17, 2023

Conversation

@jonatan-ivanov
Copy link
Contributor

@jonatan-ivanov jonatan-ivanov commented Jan 7, 2023

No description provided.

@jonatan-ivanov jonatan-ivanov mentioned this pull request Mar 22, 2023
Merged
@jonatan-ivanov
Copy link
Contributor Author

jonatan-ivanov commented May 16, 2023

Hi @halcyon,
Do you have any thoughts on this PR?
It fixes an issue I introduced while was working on the review comments of the EA builds support.

@halcyon halcyon merged commit 4f4d422 into halcyon:master May 17, 2023
@halcyon
Copy link
Owner

halcyon commented May 17, 2023

Looks good, thanks!

@jonatan-ivanov jonatan-ivanov deleted the fix-all-release-type branch May 17, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bric3 bric3 bric3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonatan-ivanov @halcyon @bric3