Update set-java-home.xsh #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [process substitution operator $() returns output with universal new lines][1] which must be stripped - $(asdf which java) returns the path name including a trailing \n; feeding that to realpath gives the error message "No such file or directory". Replaced the temporary environment variable `$java_path` with a local java variable `java_path` (without the $), the variable automatically gets discarded at the end of the scope and does not need an explicit `del`. Replaced `if len(java_path) > 0` by the equivalent but more [pythonic][2] `if java_path`. [1]: https://github.com/anki-code/xonsh-cheatsheet#3-the-process-substitution-operator--returns-output-with-universal-new-lines [2]: https://docs.python.org/3/library/stdtypes.html#truth-value-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process substitution operator $() returns output with universal new lines which must be stripped - $(asdf which java) returns the path name including a trailing \n; feeding that to realpath gives the error message "No such file or directory".
Replaced the temporary environment variable
$java_pathwith a local java variablejava_path(without the $), the variable automatically gets discarded at the end of the scope and does not need an explicitdel.Replaced
if len(java_path) > 0by the equivalent but more pythonicif java_path.