Use UTF-8 encoding when generating XML#26
Merged
Conversation
halfbyte
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first off, thanks so much for your work on this library, it's really cool!
While playing around with it, I noticed that the formatting of some German characters (ß, ö, ä, ü) was screwed up. I then compared the xml output of this library with the
factur-x.xmloutput of a third-party tool (easybill). I noticed that the first line of the xml differs:ruby-secretariat:Third-party tool (easybill):
So the conclusion here is that the encoding is set to UTF-8 explicitly and that that fixes the weird formatting of the characters.
Next, I checked how to add this to
ruby-secretariat, and the change is simply to pass the UTF-8 encoding to Nokogiri when instantiating it - check out the diff to see what I mean.This fixes the problem. The XML output now contains the
encoding="UTF-8", and the characters are formatted correctly.