Internal asserts are no longer printed, since new is_debug_active mechanism.

[mcourteaux]

In Error.h is:

Halide/src/Error.h

Lines 160 to 168 in b232c0f

	T &init(const char *file, const char *function, const int line, const char *condition_string) {
	if (debug_is_active_impl(T::verbose_debug_level, file, function, line)) {
	contents->msg << T::verbose_name << " at " << file << ":" << line << '\n';
	if (condition_string) {
	contents->msg << "Condition failed: " << condition_string << '\n';
	}
	}
	return *static_cast<T *>(this);
	}

which only conditionally appends the information about the location and error condition.

On the other hand, there is also this:

Halide/src/Error.h

Lines 176 to 178 in b232c0f

	ErrorReport &init(const char *file, const char *function, const int line, const char *condition_string) {
	return ReportBase<ErrorReport>::init(file, function, line, condition_string) << "Error: ";
	}

which appends unconditionally.

Together they combine into internal_asserts reporting like this:

Unhandled exception: Error: 

in AOT generators.

[mcourteaux]

Reading the code, I see the intention of how verbose_debug_level is supposed to be 0 for ErrorReport. However I am suspicious of this call to the superclass::init() function:

Halide/src/Error.h

Line 177 in b232c0f

return ReportBase<ErrorReport>::init(file, function, line, condition_string) << "Error: ";

While the child class is defined as:

Halide/src/Error.h

Lines 171 to 172 in b232c0f

	template<typename Exception>
	struct ErrorReport final : ReportBase<ErrorReport<Exception>> {

Where is the template parameter in the call to the super class?

[abadams]

I thought we fixed this in #8848

[alexreinking]

If I add this to the top of correctness_rfactor.cpp (arbitrary; this is the file I had open)

internal_assert(argc == 42) << "This message prints";

and run it, I see:

$ /Users/areinking/dev/Halide/build/macOS/test/correctness/correctness_rfactor
Internal error at /Users/areinking/dev/Halide/test/correctness/rfactor.cpp:1181
Condition failed: argc == 42
Error: This message prints

So it would be nice to have some repro instructions.

[mcourteaux]

Oh really? I'm so sorry. I'll rebase what I was working on on main. Perhaps this was indeed fixed.

[mcourteaux]

Yes, I can confirm it was fixed after recompiling Halide with latest main. Rookie mistake. Excuse me. 🙏