Replace ANSI Win32 API calls with UTF-16; convert UTF-8 at boundary.#5227
Merged
alexreinking merged 1 commit intomasterfrom Aug 31, 2020
Merged
Replace ANSI Win32 API calls with UTF-16; convert UTF-8 at boundary.#5227alexreinking merged 1 commit intomasterfrom
alexreinking merged 1 commit intomasterfrom
Conversation
alexreinking
force-pushed
the
win32/encodings
branch
from
5b61e5d to
f4ac195
Compare
Contributor
|
LGTM, thanks for doing this! I'll just ping @slomp to take a look as well, since he's much more experienced with Windows. |
Contributor
I would endorse moving these (and all other pathname/filesystem stuff) into Util.h, or better yet, creating a new FSUtil.h that owns all this stuff that somehow posix still can't deal with adequately... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should rethink the placement of the current directory code in
LLVM_Output.cpp. That would let me reuse the code infrom_utf8andfrom_utf16.Fixes #5223