Fix runtime build rules in Makefile#5303
Merged
steven-johnson merged 1 commit intomasterfrom Sep 30, 2020
Merged
Conversation
steven-johnson
changed the title
- one of the Windows-specific runtime files had a 32-vs-64 glitch - CMake now uses `fno-threadsafe-statics` (instead of `-std=gnu++98`) to disable thread-safe static initialization; as a result, this allowed C++11 code requirements to creep in (via d3d12compute.cpp), but we didn't notice because the Makefile wasn't properly building that file due to the 32-vs-64 glitch. Fixed by updating the Makefile to use this flag instead (which was an overdue fix anyway).
steven-johnson
force-pushed
the
srj/win-32
branch
from
cff7078 to
69aeb9e
Compare
alexreinking
approved these changes
Sep 29, 2020
Member
|
oops, thanks for the fix. |
abadams
approved these changes
Sep 29, 2020
alexreinking
added
the
backport me
alexreinking
pushed a commit
that referenced
this pull request
Oct 16, 2020
Fix runtime build rules in Makefile
alexreinking
removed
the
backport me
alexreinking
pushed a commit
that referenced
this pull request
Oct 18, 2020
Fix runtime build rules in Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fno-threadsafe-statics(instead of-std=gnu++98) to disable thread-safe static initialization; as a result, this allowed C++11 code requirements to creep in (via d3d12compute.cpp), but we didn't notice because the Makefile wasn't properly building that file due to the 32-vs-64 glitch. Fixed by updating the Makefile to use this flag instead (which was an overdue fix anyway).