Conversation
Contributor
dsharletg
commented
Nov 25, 2020
dsharletg
commented
- Lowering of shifts in CodeGen_LLVM could generate dead code.
- Some small refactors/simplifications of type matching in IROperator.
abadams
reviewed
Nov 25, 2020
abadams
reviewed
Nov 25, 2020
abadams
reviewed
Nov 25, 2020
abadams
reviewed
Nov 25, 2020
| // The signedness doesn't match, so just match the bits. | ||
| if (x.type().bits() < y.type().bits()) { | ||
| Type t; | ||
| if (x.type().is_int()) { |
Member
There was a problem hiding this comment.
what the hell was going on here? Is there something special about floats?
Contributor
Author
There was a problem hiding this comment.
I don't know. The old could would have casted floats to ints though, so I doubt it was doing something useful there.
abadams
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.