Change apps/ Makefiles handling of HL_TARGET#5539
Closed
steven-johnson wants to merge 1 commit intomasterfrom
Closed
Change apps/ Makefiles handling of HL_TARGET#5539steven-johnson wants to merge 1 commit intomasterfrom
steven-johnson wants to merge 1 commit intomasterfrom
Conversation
Always specify a Generator's `target` value as `$HL_TARGET`, rather than `$*`; this allows us more flexibility to cross-compile while adding extra features to HL_TARGET that may not be reflected in the base build tooling.
steven-johnson
added
the
skip_buildbots
Contributor
Author
|
(skipping buildbots for now since this change is controversial) |
Member
|
This breaks any workflow that involves rapidly toggling between two different targets (e.g. adding and removing -profile, or -cuda, or -debug). It makes it really easy to have the actual compiled target not match the target implied by the path. The effect is that you "make clean" and rebuild constantly. Moving away from depending on environment variables in the makefiles was a major usability improvement for me, and I'd hate to backslide. I think there are other ways to deal with the cross-compiler issue (I posted one in the other PR). |
Contributor
Author
|
Closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always specify a Generator's
targetvalue as$HL_TARGET, rather than$*; this allows us more flexibility to cross-compile while adding extra features to HL_TARGET that may not be reflected in the base build tooling.