Clone #2 of https://github.com/halide/Halide/pull/5545 for testing#5564
Closed
steven-johnson wants to merge 11 commits intomasterfrom
Closed
Clone #2 of https://github.com/halide/Halide/pull/5545 for testing#5564steven-johnson wants to merge 11 commits intomasterfrom
steven-johnson wants to merge 11 commits intomasterfrom
Conversation
OpenGL relies on the correct order of kernel args, so we can only sort the args on non-OpenGL target.
See also this commit: #5297
OpenGL runtime will use raw type pointer to retrieve the uniform value in kernel args, so we have to use C-style type definition instead of GLSL-style. See also #4702
GL 2.x does not support uint/uvec and only a subset of builtin functions support int/ivec arguments. Besides, GLES does not define round of integer division.
VAO (vertex array object) must be bind before vertex attribute array is enabled or disabled.
Bypass integer division temporarily since the latest version is far more complicated to list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.