Change warmup strategy for sliding window#5755
Merged
Conversation
Contributor
Author
|
Reopening now that those two prerequisite PRs have been merged. |
Contributor
|
Looks clean. Ready to land? |
Contributor
Author
|
I think this is ready to merge, @abadams, @rootjalex did you want to take a final look at this before merging? |
rootjalex
reviewed
Mar 8, 2021
rootjalex
reviewed
Mar 8, 2021
rootjalex
reviewed
Mar 8, 2021
rootjalex
reviewed
Mar 8, 2021
rootjalex
reviewed
Mar 8, 2021
rootjalex
reviewed
Mar 9, 2021
abadams
reviewed
Mar 11, 2021
abadams
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch changes how we handle the "warmup" of sliding windows before running the "steady state". The old strategy was to make the first iteration handle the warmup. This branch changes the strategy to "back up" the loop so the steady state warms up the loop itself, inserting the necessary ifs to guard the producer and consumer to avoid producing or consuming out of bounds values.
This change has the following impacts:
This avoids one of the motivations for #5204, and is hopefully helpful for #1820