Refactor host alignment to enable specializing#5793
Closed
Refactor host alignment to enable specializing#5793
Conversation
Member
|
I'm a bit worried about this from an IR definition perspective. The alignment of an underlying pointer is a lower-level concept than Load and Store. Load/Store/Allocate could be backed by a hash table, for example, if the allocation is only used sparsely, so while it makes sense to talk about the alignment of the index, which is an integer, I'm not sure it strictly makes sense to talk about the alignment of the memory address it represents. That's a backend-dependent property. |
Contributor
|
Monday morning review ping: where does this PR stand? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of host alignment logic to use the analysis from the simplifier, and bakes it into the Load/Store alignment.
This enables adding an
is_host_alignedhelper function forOutputImageParamthat allows specializing based on the alignment of the host pointer. This can help avoid performance regressions from #5784 in some cases.This PR loses the ability of JIT to learn alignment from the actual allocation of internal images.