Export HalidePythonExtensionHelpers.cmake for installs#6941
Merged
steven-johnson merged 9 commits intomainfrom Aug 16, 2022
Merged
Export HalidePythonExtensionHelpers.cmake for installs#6941steven-johnson merged 9 commits intomainfrom
steven-johnson merged 9 commits intomainfrom
Conversation
alexreinking
requested changes
Aug 15, 2022
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
We need to build up some more comprehensive integration testing with our CMake package to catch packaging mistakes. At the very least, it shouldn't all be in my head.
Contributor
Author
|
PTAL |
Contributor
Author
|
PTAL |
alexreinking
approved these changes
Aug 16, 2022
Member
Looks good, but I really feel the need to prioritize this now. |
alexreinking
pushed a commit
that referenced
this pull request
Aug 16, 2022
* Export HalidePythonExtensionHelpers.cmake for installs * oops * fixes * Fix broken code in target_export_script() * oops #2 * Add WITH_SOABI to stubs as well as AOT * More fixes * Update CMakePresets.json * Update CMakePresets.json
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Export HalidePythonExtensionHelpers.cmake for installs * oops * fixes * Fix broken code in target_export_script() * oops halide#2 * Add WITH_SOABI to stubs as well as AOT * More fixes * Update CMakePresets.json * Update CMakePresets.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions in this will be helpful to end-users and should be exported, installed, and documented. (Note that both are actually related to Generators and Python; it might make more sense just to move them to the existing HalideGeneratorHelpers file?)