Fix dubious find_package logic in test/generator#8804
Conversation
|
The failing ruff check is fixed in #8803 |
|
I'm not sure I follow the original or new logic. HL_TARGET containing "cuda" definitely doesn't imply any build-time dependence on anything cuda-related, toolkit or driver. But I see there's an explicit include of cuda.h in test/common/gpu_context.h and this is included by acquire_release_aottest.cpp. So this is usage of the cuda toolkit that happens independently from Halide's use of cudaI Is sniffing HL_TARGET just a proxy for tests that might potentially depend on the toolkit? Would it be better/clearer to just explicitly declare that those specific tests depend on the toolkit? I think it's just acquire_release_aottest.cpp and gpu_multi_context_threaded_aottest.cpp. For opencl, it's those two plus define_extern_opencl_aottest.cpp |
It would be cleaner; I updated the PR.
nit: It's not independent because the header is only included by |
Fixes #8790