Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FetchContent is an absolute nightmare of a dependency management feature. The fact that it brings third-party CMake code into your build without any kind of isolation has been a long source of headaches. Over the years, I've had to nearly rewrite wabt's build system, contribute patches to CMake, hack around missing features, write extra detection modules, and complicate our packaging rules just to skip a simple installation step (e.g.
brew install wabt flatbuffers).This is the first step towards excising FetchContent from the codebase.
Opening this as a draft for now. I plan to add wheels for flatbuffers and wabt to pypi.halide-lang.org to make getting dependencies easy.