Merged
Conversation
alexreinking
force-pushed
the
alexreinking/fix-make-workflow
branch
from
5029972 to
6931f03
Compare
* Make workflow much less eager * Check status rather than use continue-on-error, which suppresses failures * Install pybind11 on macOS
alexreinking
force-pushed
the
alexreinking/fix-make-workflow
branch
from
6931f03 to
59d80af
Compare
abadams
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile workflow was silently swallowing test failures because every test step used
continue-on-error: true. This replaces that withif: !cancelled()so that failures are reported while still running subsequent test stages. Also expandspaths-ignoreto avoid triggering on unrelated files and checks theParseFromStringresult inapps/onnx/model.cpp, which was found by the Make build.This also drops testing on Intel macs specifically, since nobody we know uses that configuration (with make) and macOS runners are precious in terms of available parallelism