Merged
Conversation
Took out the stuff from fuzz_simplifier, and fuzz_extract_lanes from the other PR. Now everything broke, because the new Expr generator produces MORE expressions, which uncovers many bugs.
6 tasks
Contributor
Author
|
Making the expression generator configurable, such that I can disable the things on which it fails, in order to be able to continue with this PR without having to fix all the bugs. |
Disable expression types that trip the simplifier.
mcourteaux
force-pushed
the
shared-fuzz-expr-gen
branch
from
1c4b779 to
ec1a1f7
Compare
alexreinking
approved these changes
Mar 17, 2026
Member
alexreinking
left a comment
alexreinking
left a comment
There was a problem hiding this comment.
This looks great! I especially like the configurability options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of #9044
Took out the stuff from
fuzz_simplifier, andfuzz_extract_lanesfrom the other PR. Now everything broke, because the new Expr generator produces MORE kinds of expressions, which uncovers many bugs.(Intentionally pushing to halide/Halide to encourage collaborative fixes, @abadams)
Update: made the expression generator configurable, such that we can disable the generation of expressions that trip up the simplifier.