Merged
Conversation
…de/Halide into alexreinking/better-fuzzing
mcourteaux
approved these changes
Mar 16, 2026
Contributor
mcourteaux
left a comment
mcourteaux
left a comment
There was a problem hiding this comment.
I few questions, but LGTM.
| debug(0) << arg; | ||
| }; | ||
| (dump(args), ...); | ||
| debug(0) << "\n"; |
Contributor
There was a problem hiding this comment.
Is the order backwards?
Member
There was a problem hiding this comment.
The C++17 fold didn't work with the way debug changed, but we didn't notice because it was ifdef'd-out debugging code.
mcourteaux
reviewed
Mar 16, 2026
mcourteaux
requested changes
Mar 16, 2026
6 tasks
mcourteaux
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables writing fuzz tests that are compatible with libFuzzer, but do not require it. When building without libFuzzer globally enabled, the build will fall back to a simple command line runner and a std::mt19937_64 randomness source.
We also add a toolchain for macOS with Homebrew and a preset that uses it to build with libFuzzer. I have tested this locally to work both ways. The buildbots should immediate start building and testing with the stdlib backend.