Delete newline that causes formatting issue on Github.#9054
Merged
mcourteaux merged 5 commits intomainfrom Mar 17, 2026
Merged
Conversation
Hopefully this was not a precommit auto-fix?
mcourteaux
added
the
skip_buildbots
Contributor
Author
|
@alexreinking Hopefully a config fix in mdformat is possible here. |
Contributor
Author
Member
We already have that configured... - repo: https://github.com/hukkin/mdformat
rev: 1.0.0
hooks:
- id: mdformat
args: [ --number, --wrap=80 ]
additional_dependencies:
- mdformat-gfm
- mdformat-ruff
- mdformat-shfmt |
Contributor
Author
|
Don't you have to use the other one as actual repo instead of dependency? |
mdformat-gfm doesn't understand GitHub's checklists.
mcourteaux
force-pushed
the
mcourteaux-pr-template-newline
branch
from
9f636c0 to
5dde0a7
Compare
alexreinking
force-pushed
the
mcourteaux-pr-template-newline
branch
from
5dde0a7 to
9f636c0
Compare
Member
|
Opened hukkin/mdformat-gfm#58 |
Contributor
Author
|
Go ahead and approve your own work. I approve. |
alexreinking
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this was not a precommit auto-fix?
It was. Alex to the rescue.