fix: rendering issue due to missing default values#139
Merged
JohnNiang merged 2 commits intohalo-dev:mainfrom Jun 28, 2024
Merged
fix: rendering issue due to missing default values#139JohnNiang merged 2 commits intohalo-dev:mainfrom
JohnNiang merged 2 commits intohalo-dev:mainfrom
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
Bot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
guqing
requested changes
Jun 28, 2024
Member
guqing
left a comment
guqing
left a comment
There was a problem hiding this comment.
建议撤销这些改动然后在
给定初始化为 CaptchaConfig.empty() 即可，原因是序列化时没有值不会走 set 方法，这里忘记写默认值导致的Signed-off-by: Ryan Wang <i@ryanc.cc>
ruibaby
added a commit
to ruibaby/plugin-comment-widget
that referenced
this pull request
Aug 8, 2024
* fix: rendering issue due to missing default values Signed-off-by: Ryan Wang <i@ryanc.cc> * Set default values for captcha Signed-off-by: Ryan Wang <i@ryanc.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为验证码相关的配置添加默认值，以解决升级之后页面渲染异常的问题，需要注意，FormKit 的 group 类型不能只在其下输入框设置默认值，需要在 group 节点设置。
/kind bug
Fixes #137