Skip to content

Fix incorrect link protocol problem#18

Merged
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
FTL1ght:ftl1ght
Sep 27, 2023
Merged

Fix incorrect link protocol problem#18
f2c-ci-robot[bot] merged 2 commits intohalo-dev:mainfrom
FTL1ght:ftl1ght

Conversation

@FTL1ght
Copy link
Copy Markdown
Contributor

@FTL1ght FTL1ght commented Sep 27, 2023

Fixes #17

修复:rss 中生成的 link 字段协议不正确

@f2c-ci-robot f2c-ci-robot Bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot Bot requested review from ruibaby and wan92hen September 27, 2023 07:29
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @FTL1ght for the first contribution!

因为 externalUrlSupplier#getRaw 方法是 2.7.0 才有的,所以可能需要同步修改一下最低版本要求:

requires: ">=2.4.0"

@f2c-ci-robot f2c-ci-robot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 27, 2023
@JohnNiang
Copy link
Copy Markdown
Member

/retitle Fix incorrect link protocol problem

@f2c-ci-robot f2c-ci-robot Bot changed the title 修复:rss 中生成的 link 字段协议不正确 Fix incorrect link protocol problem Sep 27, 2023
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot Bot merged commit b3b8f32 into halo-dev:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rss 中生成的 link 字段协议可能不正确

2 participants