Skip to content

fix: replace author tag with dc:creator to specify the author #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guqing merged 1 commit into from
Dec 16, 2024
Merged

fix: replace author tag with dc:creator to specify the author #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/src/main/java/run/halo/feed/RssXmlBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public String toXmlString() {

Element root = DocumentHelper.createElement("rss");
root.addAttribute("version", "2.0");
root.addNamespace("dc", "http://purl.org/dc/elements/1.1/");
root.addNamespace("media", "http://search.yahoo.com/mrss/");
document.setRootElement(root);

Expand Down Expand Up @@ -167,7 +168,9 @@ private void createItemElementToChannel(Element channel, RSS2.Item item) {
.addText(item.getGuid());

if (StringUtils.isNotBlank(item.getAuthor())) {
itemElement.addElement("author").addText(item.getAuthor());
// https://www.rssboard.org/rss-validator/docs/error/InvalidContact.html
itemElement.addElement("dc:creator")
.addText(item.getAuthor());
}

if (StringUtils.isNotBlank(item.getEnclosureUrl())) {
Expand Down
8 changes: 5 additions & 3 deletions app/src/test/java/run/halo/feed/RSS2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ void toXmlString() {
// language=xml
var expected = """
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:media="http://search.yahoo.com/mrss/" version="2.0">
<rss xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:media="http://search.yahoo.com/mrss/" version="2.0">
<channel>
<title>title</title>
<link>link</link>
Expand Down Expand Up @@ -109,7 +110,7 @@ void extractRssTagsTest() {
// language=xml
var expected = """
<?xml version="1.0" encoding="UTF-8"?>
<rss
<rss xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:media="http://search.yahoo.com/mrss/" version="2.0">
<channel>
<title>title</title>
Expand Down Expand Up @@ -161,7 +162,8 @@ void invalidCharTest() {
// language=xml
var expected = """
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:media="http://search.yahoo.com/mrss/" version="2.0">
<rss xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:media="http://search.yahoo.com/mrss/" version="2.0">
<channel>
<title>title</title>
<link>link</link>
Expand Down