Skip to content

feat: support selecting groups to join when link#165

Merged
f2c-ci-robot[bot] merged 4 commits intohalo-dev:mainfrom
longjuan:feat/group
Jul 31, 2024
Merged

feat: support selecting groups to join when link#165
f2c-ci-robot[bot] merged 4 commits intohalo-dev:mainfrom
longjuan:feat/group

Conversation

@longjuan
Copy link
Copy Markdown
Member

fixes #152

S3关联时支持选择加入的分组

image

@f2c-ci-robot f2c-ci-robot Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 19, 2024
@f2c-ci-robot f2c-ci-robot Bot requested review from JohnNiang and wan92hen July 19, 2024 14:46
Copy link
Copy Markdown
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@longjuan
Copy link
Copy Markdown
Member Author

/ping @halo-dev/sig-halo

Copy link
Copy Markdown
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@f2c-ci-robot f2c-ci-robot Bot merged commit 97f653b into halo-dev:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S3 存储策略的建议

3 participants