Skip to content

feat: support robots.txt router#19

Merged
JohnNiang merged 1 commit intohalo-dev:mainfrom
AirboZH:feat/robots_txt
Sep 18, 2023
Merged

feat: support robots.txt router#19
JohnNiang merged 1 commit intohalo-dev:mainfrom
AirboZH:feat/robots_txt

Conversation

@AirboZH
Copy link
Copy Markdown
Member

@AirboZH AirboZH commented Sep 14, 2023

示例站点: https://airbozh.tech/robots.txt

由于更希望以绝对地址来显示sitemap,所以规则设置中省去了sitemap的设置
统一设置为host/sitemap.xml,这与插件的sitemap路由一致

Resolve #18

新增支持 robots.txt 路由以及编辑 robots.txt 规则

@f2c-ci-robot f2c-ci-robot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2023
Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
Comment thread src/main/resources/extensions/settings.yml Outdated
Comment thread src/main/resources/extensions/settings.yml Outdated
Comment thread src/main/resources/extensions/settings.yml Outdated
@AirboZH AirboZH requested a review from guqing September 15, 2023 08:43
@AirboZH
Copy link
Copy Markdown
Member Author

AirboZH commented Sep 15, 2023

等一下,可能需要做一下缓存控制。测试发现robots.txt会被缓存,配置更新不及时

@AirboZH
Copy link
Copy Markdown
Member Author

AirboZH commented Sep 15, 2023

已解决,可以review了

Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
Copy link
Copy Markdown
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@guqing
Copy link
Copy Markdown
Member

guqing commented Sep 18, 2023

/ping @halo-dev/sig-halo

Comment thread src/main/resources/extensions/settings.yml Outdated
@AirboZH AirboZH requested a review from ruibaby September 18, 2023 03:58
Comment thread src/main/resources/extensions/settings.yml Outdated
Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
Copy link
Copy Markdown
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 18, 2023
Comment thread src/main/java/run/halo/sitemap/SitemapPluginConfig.java Outdated
fix: Modify default rules

chore: set default rule

当自定义规则开关关闭时,默认disallow /console
修改了代码样式细节

fix: 修复缓存导致调整robots_txt_enable失效的问题

chore: 修改缓存控制代码

docs: 修改label名

Co-authored-by: Ryan Wang <i@ryanc.cc>

chore: 格式化代码

chore: 设置项改名
@AirboZH AirboZH requested a review from ruibaby September 18, 2023 05:07
Copy link
Copy Markdown
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@guqing guqing added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang merged commit 9658e83 into halo-dev:main Sep 18, 2023
@AirboZH AirboZH deleted the feat/robots_txt branch September 18, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

支持robots.txt

4 participants