fix: correct URL double-escaping in sitemap generation#45
Merged
ruibaby merged 2 commits intohalo-dev:mainfrom Apr 27, 2026
Merged
fix: correct URL double-escaping in sitemap generation#45ruibaby merged 2 commits intohalo-dev:mainfrom
ruibaby merged 2 commits intohalo-dev:mainfrom
Conversation
UrlUtils.toURI() was calling escapeSitemapUrl() internally, while SitemapGeneratorOptions.transform() already called it before passing the URL to toURI(). This caused & to be escaped twice: & -> & -> &, producing invalid URLs in the generated sitemap. Remove the redundant escapeSitemapUrl() call from toURI() so that callers are solely responsible for escaping. Update the test assertion to reflect the correct (single-escaped) output. Made-with: Cursor
f2c-ci-robot
Bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f2c-ci-robot
Bot
added
the
needs-rebase
Resolve conflict in SitemapGeneratorOptionsTest: keep the UrlEntryMeta API introduced in upstream/main while applying the corrected expected value from this branch (single-escaped <>& instead of the double-escaped &lt;&gt;&amp; produced by the bug). Made-with: Cursor
f2c-ci-robot
Bot
added
release-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UrlUtils.toURI()was callingescapeSitemapUrl()internally, whileSitemapGeneratorOptions.transform()already called it before passing the URL in&to be escaped twice:&→&→&amp;, producing invalid URLs in the generated sitemapescapeSitemapUrl()call fromtoURI()so that callers are solely responsible for XML entity escapingTest plan
SitemapGeneratorOptionsTest.transform()— verify the absolute URL case now produces single-escaped output (</>/&instead of&lt;/&gt;/&amp;)Made with Cursor