fix: remove changefreq/priority and fix lastmod per Google/Bing guidelines#46
Merged
ruibaby merged 1 commit intohalo-dev:mainfrom Apr 27, 2026
Merged
Conversation
f2c-ci-robot
Bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f2c-ci-robot
Bot
added
needs-rebase
…lines Google and Bing both ignore changefreq and priority fields in sitemaps. Remove these fields from SitemapEntry, SitemapGeneratorOptions, and SitemapBuilder to avoid generating misleading metadata. Also remove the Instant.now() fallback for lastmod in transform(): only set lastmod when UrlEntryMeta actually carries a real modification time, preventing inaccurate timestamps that could mislead crawlers. Made-with: Cursor
ruibaby
force-pushed
the
fix/seo-fields-alignment
branch
from
45cd729 to
4444565
Compare
f2c-ci-robot
Bot
added
release-note-none
f2c-ci-robot
Bot
added
release-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changefreqandpriorityare ignored (Build a Sitemap · Google Search Central)lastmodis consistently set to the generation time rather than real modification date, they will distrust and discard it site-wide — which is exactly what the previousInstant.now()fallback caused for categories/tags/archivesChanges
ChangeFreqEnum.java(no longer referenced anywhere)changefreqandpriorityfields fromSitemapEntrySitemapBuilder.normalizeSitemapEntry()SitemapGeneratorOptions:allowEmptySitemap,allowMultipleSitemaps,sitemapSize,autoValidate,gzip,generateIndexSitemap,fileNamePrefix,autoLastmodtransform()now produces only<loc>; proper<lastmod>support per content type will follow in a subsequent PRSitemapBuilderTestandSitemapGeneratorOptionsTestaccordinglyTest plan
SitemapBuilderTest— generated XML contains only<loc>and<lastmod>(when present); no<changefreq>or<priority>tagsSitemapGeneratorOptionsTest—transform()produces correctlocand nulllastmod/sitemap.xmlis valid XML and passes sitemap validatorsMade with Cursor