refactor: fix reactive anti-pattern and cache key in CachedSitemapGetter#47
Merged
ruibaby merged 1 commit intohalo-dev:mainfrom Apr 27, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Replace Guava Cache with Caffeine AsyncCache to eliminate the blocking .block() call inside a reactive pipeline, which can cause thread starvation on bounded schedulers. Use options.getSiteUrl().toString() as the cache key instead of the SitemapGeneratorOptions object itself. java.net.URL.equals() performs DNS resolution on every comparison, making it unsuitable as a map/cache key. Made-with: Cursor
6ebf3d0 to
1bd60c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three issues in the previous
CachedSitemapGetterimplementation:Guava Cache.get(key, Callable)was used with.block()inside the callable. This is a reactive anti-pattern — even onSchedulers.boundedElastic(), nesting.block()inside a Guava cache loader risks deadlock under concurrent load.SitemapGeneratorOptions(which containsjava.net.URL) was used as the cache key.URL.equals()andURL.hashCode()perform DNS resolution on every cache lookup, which is a well-known Java gotcha.cache.put(): Guava'scache.get(key, callable)automatically stores the callable result — the explicitcache.put()call afterward was redundant.Changes
Cachewith CaffeineAsyncCache<String, String>siteUrl.toString()as the cache key (plainString, no DNS lookup)CompletableFuturedirectly from the reactive pipeline (.toFuture()), wrapped inMono.fromFuture()— no.block()anywhereTest plan
CachedSitemapGetterTest.get()— lister is called exactly once even with 10 concurrent requests hitting the same keyMade with Cursor