fix: improve sitemap content correctness in DefaultSitemapEntryLister#48
Merged
ruibaby merged 1 commit intohalo-dev:mainfrom Apr 27, 2026
Merged
Conversation
f2c-ci-robot
Bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
f2c-ci-robot
Bot
added
needs-rebase
- Filter out null/blank permalinks in all list*Urls() methods to prevent IllegalArgumentException when UrlEntryMeta is constructed with a blank URL - Add homepage '/' to urlsForListPages() so the root URL is always included - Remove redundant Objects.equals(false, singlePage.getSpec().getDeleted()) check in listSinglePageUrls(): ExtensionOperator.isNotDeleted() already covers this condition - Remove stale TODO comment in urlsForListPages() Made-with: Cursor
ruibaby
force-pushed
the
fix/sitemap-entry-lister
branch
from
1179af4 to
c5bff70
Compare
f2c-ci-robot
Bot
added
release-note-none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four correctness issues in
DefaultSitemapEntryLister:Null permalink crash:
post.getStatusOrDefault().getPermalink()can returnnullfor posts/pages that haven't had their permalink computed yet. Emittingnullin a Reactor stream causes an immediateNullPointerException, aborting the entire sitemap generation. Added.filter(StringUtils::isNotBlank)after each permalink mapping.Missing homepage: The site root
/was never included in the sitemap. Added it as the first entry inurlsForListPages().Inconsistent SinglePage deletion check:
Postuses!post.isDeleted()for deletion filtering, whileSinglePageadditionally hadObjects.equals(false, singlePage.getSpec().getDeleted())— a redundant check that duplicates whatExtensionOperator.isNotDeleted()already covers. Removed the redundant predicate to unify the logic.Stale TODO comment: Removed
// TODO 优化系统其他路由获取from production code.Test plan
/sitemap.xmlincludes the site homepage/Made with Cursor