Skip to content

refactor: optimizing project structure and configuration#10

Merged
f2c-ci-robot[bot] merged 3 commits intomainfrom
refactor/project-configuration
May 11, 2023
Merged

refactor: optimizing project structure and configuration#10
f2c-ci-robot[bot] merged 3 commits intomainfrom
refactor/project-configuration

Conversation

@guqing
Copy link
Copy Markdown
Member

@guqing guqing commented May 11, 2023

What this PR does?

优化项目配置

  • 使用 Halo plugin maven 依赖替换原先 lib 依赖,为了此依赖必须将 gradle 升级至 8 版本
  • 将 resources/console 加入到 .gitignore 中
  • 增加了 .editconfig 配置
None

@f2c-ci-robot f2c-ci-robot Bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 11, 2023
@f2c-ci-robot f2c-ci-robot Bot requested review from JohnNiang and ruibaby May 11, 2023 04:07
@longjuan
Copy link
Copy Markdown
Member


改成2.5.0?

@guqing
Copy link
Copy Markdown
Member Author

guqing commented May 11, 2023

改成2.5.0?

good catch🎉

Copy link
Copy Markdown
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
Comment thread build.gradle Outdated
@f2c-ci-robot f2c-ci-robot Bot removed the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot Bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot merged commit b82aa93 into main May 11, 2023
@guqing guqing deleted the refactor/project-configuration branch May 11, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants