fix: truncate default start date filter to start of day #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
getFilterStartDateusesDateTime.now()if an entry was created Monday morning at 0800, and I come back to check Timecop, same Monday, at 1200 with the "auto start date Monday filter" activated in the settings, the 0800 entry won't show up.Using
DateTime.copyWithallows us to truncate the current date to the start of the day.This issue still arises even with the "auto start date Monday filter" turn off, since all entries prior (in terms of hour:minute:second) to the current time won't show up.