fix(typing): Added __all__ to package root#190
Merged
offbyone merged 2 commits intohamcrest:mainfrom Dec 12, 2021
last-partizan:main
Merged
fix(typing): Added __all__ to package root#190offbyone merged 2 commits intohamcrest:mainfrom last-partizan:main
offbyone merged 2 commits intohamcrest:mainfrom
last-partizan:main
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
offbyone
reviewed
Dec 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing
__all__in package root, core and library.After adding this, pyright correctly recognizes all imports.
I tried to minimize names duplication, and used
__all__.extendsyntax where possible. (This is valid option, as explained here https://github.com/microsoft/pyright/blob/main/docs/typed-libraries.md#library-interface).But it doesn't seem to work recursively, so we can use it only once per import hierarchy.
Closes #175