Addition of Stellarator to OPENPOPCON#31
Conversation
resources/.DS_Store
Outdated
There was a problem hiding this comment.
Please remove .DS_Store files from the GitHub
resources/examples/.DS_Store
Outdated
There was a problem hiding this comment.
Please remove .DS_Store files from the GitHub
.DS_Store
Outdated
There was a problem hiding this comment.
Please remove .DS_Store files from the GitHub
There was a problem hiding this comment.
Please remove .DS_Store files from the GitHub
src/.DS_Store
Outdated
There was a problem hiding this comment.
Please remove .DS_Store files from the GitHub
There was a problem hiding this comment.
What is this file? I think we should remove the .ipynb_checkpoints files from the GitHub. If they are important to running we should find a way to merge with the main example.
There was a problem hiding this comment.
What is this file? I think we should remove the .ipynb_checkpoints files from the GitHub. If they are important to running we should find a way to merge with the main example.
examples/stellarator_vmec_example.py
Outdated
There was a problem hiding this comment.
What is this file? I think we should remove the .ipynb_checkpoints files from the GitHub. If they are important to running we should find a way to merge with the main example.
There was a problem hiding this comment.
Can you clean this up now that we don't need t3d?
nelsonand
changed the title
|
@sushipand954 There are still a few unresolved comments from last time here eg: https://github.com/hansec/OpenPOPCON/pull/31/files#r2617278022 Can you please clean these up? |
| R: 4.55 # major radius in meters | ||
| a: 1.2 # minor radius in meters | ||
| kappa: 1.4 # elongation | ||
| delta: -0.5 # triangularity |
There was a problem hiding this comment.
Make sure that these agree with the geometry in the vmec file
|
|
||
| #---------------------- | ||
| # I_P and q* can be calculated from each other. Pick one to specify: | ||
| I_P: 10. # plasma current in MA |
There was a problem hiding this comment.
Plasma current for a stellarator should be 0
|
|
||
| #---------------------- | ||
| # B_0 and B_coil can be calculated from each other. Pick one to specify: | ||
| B_0: 11.0 # on-axis magnetic field in Tesla |
There was a problem hiding this comment.
Make sure this agrees with the vmec file
| gfilename: "gMANTA" | ||
| profsfilename: "profsMANTA.csv" |
There was a problem hiding this comment.
These shouldn't be point to MANTA... this example should call the vmec file.
There was a problem hiding this comment.
@sushipand954 This is an important one - what is the difference between this and src/openpopcon.py
There was a problem hiding this comment.
ping - Are these supposed to be the stellarator profiles? If so, call them as such
There was a problem hiding this comment.
It looks like there is some duplicate code between this and src/lib/test_vmec.py. We should avoid that to prevent the issue down the line of a user editing one and not the other. Can you clean this up?
My vote: all of the code needed to read the vmec equilibria should be in a file in src/lib. I agree that it would be good to keep a test_vmec script around, but this test should simply just call the class definition from the main script and employ it directly (avoid specifying any actual file-reading code twice.)
There was a problem hiding this comment.
ping on this - do we really need t3d as a submodule?
2 participants
Generalized openpopcon to stellarator geometry