Hdd-1443 export ready fields with indents#3
Merged
jack-happydoc merged 4 commits intomasterfrom Jan 14, 2025
Merged
Conversation
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0c8367d in 22 seconds
More details
- Looked at
45lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. lib/format.js:74
- Draft comment:
Removing the space betweenrtfwrapperandtextmight cause rendering issues for RTF elements that require a space between the control word and the text. Consider adding a space if necessary. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_E6p6bo23oKoPH2X9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
|
||
| //close doc | ||
| rtf+="}"; | ||
| rtf+="}\n"; |
Author
There was a problem hiding this comment.
just for my own ability to read the underlying markdown. makes it so that the entire RTF doc isn't on a single line, has no impact on the rendered output
tim-happydoc
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add space for proper RTF rendering and newline in
formatText()informat.js, update version inpackage.json.formatText()informat.jsto ensure proper RTF rendering.formatText()informat.js.package.jsonfrom0.0.2to0.0.3.This description was created by
for 0c8367d. It will automatically update as commits are pushed.