Skip to content

Hdd-1443 export ready fields with indents#3

Merged
jack-happydoc merged 4 commits intomasterfrom
HDD-1443-Export-ready-fields-with-indents
Jan 14, 2025
Merged

Hdd-1443 export ready fields with indents#3
jack-happydoc merged 4 commits intomasterfrom
HDD-1443-Export-ready-fields-with-indents

Conversation

@jack-happydoc
Copy link
Copy Markdown

@jack-happydoc jack-happydoc commented Jan 13, 2025

Important

Add space for proper RTF rendering and newline in formatText() in format.js, update version in package.json.

  • Behavior:
    • Add space in formatText() in format.js to ensure proper RTF rendering.
    • Add newline character at the end of RTF document in formatText() in format.js.
  • Versioning:
    • Update version in package.json from 0.0.2 to 0.0.3.

This description was created by Ellipsis for 0c8367d. It will automatically update as commits are pushed.

Copy link
Copy Markdown

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0c8367d in 22 seconds

More details
  • Looked at 45 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. lib/format.js:74
  • Draft comment:
    Removing the space between rtfwrapper and text might cause rendering issues for RTF elements that require a space between the control word and the text. Consider adding a space if necessary.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_E6p6bo23oKoPH2X9


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Comment thread lib/format.js

//close doc
rtf+="}";
rtf+="}\n";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the newline?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for my own ability to read the underlying markdown. makes it so that the entire RTF doc isn't on a single line, has no impact on the rendered output

@jack-happydoc jack-happydoc merged commit 75e20c4 into master Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants