Fix imports #40
Closed
Fix imports #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@chfuller-petsmart Thanks for the PR. We'll try it out and update you soon. |
Contributor
Author
|
Hey, thanks for the quick response. Sounds great. We'll look out for the update. Thanks! |
Contributor
Author
|
Sorry, just realized this PR is asking to merge to master. Should we redo it asking to merge to develop? |
Contributor
|
@chfuller-petsmart Yes. That would be appropriate. Thanks for understanding the flow. |
Contributor
Author
|
Done. #44 |
Contributor
|
Cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply fixes incorrect imports that prevent the code from compiling on a brand new Xcode project. (Apple changed the default setup for new Xcode projects related to imports and also removed the precompiled header). This PR allows the code to compile on a brand new Xcode project without any config changes. Thanks!