Skip to content

Conversation

@msimerson
Copy link
Member

@msimerson msimerson commented May 21, 2019

  • probably worked in node 12.2
  • broken in 12.3 due to this bug
  • will probably work again after 12.3.1

@msimerson
Copy link
Member Author

msimerson commented May 21, 2019

  • wait for 12.3.1 to be released
  • re-run Travis tests
  • if success, merge

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #2650 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   59.69%   59.73%   +0.03%     
==========================================
  Files          29       29              
  Lines        6387     6387              
  Branches     1587     1587              
==========================================
+ Hits         3813     3815       +2     
+ Misses       2574     2572       -2
Impacted Files Coverage Δ
server.js 40.59% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b117e55...8777585. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #2650 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   59.69%   59.73%   +0.03%     
==========================================
  Files          29       29              
  Lines        6387     6387              
  Branches     1587     1587              
==========================================
+ Hits         3813     3815       +2     
+ Misses       2574     2572       -2
Impacted Files Coverage Δ
server.js 40.59% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b117e55...8777585. Read the comment docs.

@msimerson msimerson merged commit 0d06fed into haraka:master May 23, 2019
@msimerson msimerson deleted the node12 branch May 23, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant