Skip to content

added HB_CURLOPT_MAXLIFETIME_CONN and HB_CURLOPT_DEBUGBLOCK #270

Merged
mlacecilia merged 1 commit intoharbour:masterfrom
APerricone:master
Nov 4, 2022
Merged

added HB_CURLOPT_MAXLIFETIME_CONN and HB_CURLOPT_DEBUGBLOCK #270
mlacecilia merged 1 commit intoharbour:masterfrom
APerricone:master

Conversation

@APerricone
Copy link
Copy Markdown
Contributor

@APerricone APerricone commented Oct 25, 2022

Because the 266 is lost

  * contrib\hbcurl\hbcurl.ch
  * contrib\hbcurl\core.c
    + added HB_CURLOPT_MAXLIFETIME_CONN to setup max lifetime of connection
      see https://curl.se/libcurl/c/CURLOPT_MAXLIFETIME_CONN.html for more 
      information.

2022-05-02 08:38 UTC+0200 Antonino Perricone
  * contrib\hbcurl\core.c
    + added HB_CURLOPT_DEBUGBLOCK to setup a block for debug information
      It takes a callback in the form of {|type, msg| ... }
      see https://curl.se/libcurl/c/CURLOPT_DEBUGFUNCTION.html for more 
      information.
  * contrib\hbcurl\hbcurl.ch
    + added HB_CURLINFOTYPE_* macros for debug block
@APerricone
Copy link
Copy Markdown
Contributor Author

@lailton There is it

@lailton
Copy link
Copy Markdown
Contributor

lailton commented Nov 3, 2022

Looks good to me

@mlacecilia mlacecilia merged commit 629ad68 into harbour:master Nov 4, 2022
@snaiperis
Copy link
Copy Markdown
Member

I see changelog entry:

    * contrib\hbcurl\hbcurl.ch
        + added HB_CURLINFOTYPE_* macros for debug block

but no HB_CURLINFOTYPE_* defines added to hbcurl.ch

@lailton
Copy link
Copy Markdown
Contributor

lailton commented Jan 19, 2023

The debug mentioned is related to:

#define HB_CURLOPT_DEBUGFUNCTION 94
#define HB_CURLOPT_DEBUGDATA 95
#define HB_CURLOPT_DEBUGBLOCK 1013

LGTM

@APerricone
Copy link
Copy Markdown
Contributor Author

i will do another pull request with the defines with CURLINFOTYPE as explaned here https://curl.se/libcurl/c/CURLOPT_DEBUGFUNCTION.html
ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants