Skip to content

send_periodic does not accept on_error callback, resulting in race condition #1282

@andebjor

Description

@andebjor

Describe the bug

When setting up a periodic send task there is no way to configure the on_error callback in the task. Therefore, if the very first send attempt in the task fails, the task is aborted. This can happen before the user is able to add a callback to the newly created task. Thus there is a race condition between creating the task and sending the first message, and adding the callback.

To Reproduce

Open a bus and create a periodic task. If sending to the bus fails, the task is aborted due to no callback being configured.

Expected behavior

An argument is added to send_periodic such that the callback can be set in the constructor of the task.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions