-
Notifications
You must be signed in to change notification settings - Fork 659
Closed
Description
There are a number of problems with the message object and the file IO:
- make
__eq__()take into account all fields excepttimestamp; addedchannelanderror_state_indicator - should the timestamp really be excluded?
- added
channel,bitrate_switchanderror_state_indicatorto__str__() -
__init__()is now properly documented - added a
checkparam to__init__()that then checks the input, and only then - Writing and then reading a message does not reproduce the same message again; this will be surprising to new users. This is rather a problem of the IO module and the only partial CAN FD support. ⇒ added warning to docs
- Should we add a deprecation notice to
Message.id_type? - add
__bytes__support - use
__slots__for faster attribute access & space savings in memory - adjusted/extended
logformat_test.py - add tests
In general: Surprises are bad (when programming). So I suppose we change some of the above.
Note: I am currently working on these on the change-messages branch an track my work here.