Add specific exceptions #1025
Merged
Add specific exceptions #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started to use the new exception types.
…d. The method returns True on success and False on timeout, if the user wanted an timeout.
Win32 and cygwin will both load "vcimpl.dll". Added comments.
Change version to 4.0.0.dev0 Fix classifiers in setup.py, it should be a list.
…/python-can into exception-handling
General exception handling (+ changes to the ixxat interface)
Codecov Report
@@ Coverage Diff @@
## develop #1025 +/- ##
========================================
Coverage 70.82% 70.82%
========================================
Files 78 79 +1
Lines 7567 7588 +21
========================================
+ Hits 5359 5374 +15
- Misses 2208 2214 +6 |
felixdivo
changed the title
Collaborator
Author
|
Seems like this can be merged soon. Not too much would need to be done. |
felixdivo
changed the title
Collaborator
Author
|
After this is merged, I'd open new issues/PRs for:
These would need to be closed before 4.0.0 is release. I can offer to do part of it. |
felixdivo
commented
Apr 22, 2021
hardbyte
reviewed
Apr 23, 2021
Collaborator
Author
|
@Mergifyio update |
Contributor
|
Command
|
Collaborator
Author
|
@hardbyte Can this be merged then? |
hardbyte
approved these changes
May 9, 2021
This was referenced May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
can/*.pymodulescan/io/*.pymodules (it is not used there anyways, and that is correct)Closes #356. This PR is based on the work of @marcel-kanter done in #562.