Skip to content

Fix VectorError bug #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixdivo merged 1 commit into from
Jun 5, 2021
Merged

Fix VectorError bug #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions can/interfaces/vector/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@

class VectorError(CanError):
def __init__(self, error_code, error_string, function):
self.error_code = error_code
super().__init__(f"{function} failed ({error_string})")
super().__init__(
message=f"{function} failed ({error_string})", error_code=error_code
)

# keep reference to args for pickling
self._args = error_code, error_string, function
Expand Down
1 change: 0 additions & 1 deletion test/test_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ def test_called_without_testing_argument(self) -> None:
# do not set the _testing argument, since it suppresses the exception
can.Bus(channel=0, bustype="vector")

@unittest.skip("Fixing this is deferred until Vector is adjusted after #1025")
def test_vector_error_pickle(self) -> None:
error_code = 118
error_string = "XL_ERROR"
Expand Down