Specific Exceptions: Adapting neousys (+ bugfixes & simplifications) #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1076 +/- ##
===========================================
+ Coverage 68.87% 72.27% +3.39%
===========================================
Files 79 79
Lines 7618 7610 -8
===========================================
+ Hits 5247 5500 +253
+ Misses 2371 2110 -261 |
felixdivo
force-pushed
the
felixdivo-issue-1046-neousys
branch
from
21c071a to
d94bad0
Compare
21 tasks
hardbyte
approved these changes
Jun 8, 2021
Comment on lines
+226
to
+227
| except queue.Full: | ||
| raise CanOperationError("Neousys message Queue is full") from None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1046. To implement the changes, the error handling has been changed to throw errors instead of logging. Other parts of the code have been simplified. Potential race conditions have been removed. Adds support for timeouts when receiving.