Specific Exceptions: Adapting usb2can interface (+ simplify + partially type) #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1091 +/- ##
===========================================
+ Coverage 70.66% 70.99% +0.32%
===========================================
Files 79 79
Lines 7616 7588 -28
===========================================
+ Hits 5382 5387 +5
+ Misses 2234 2201 -33 |
hardbyte
approved these changes
Jul 14, 2021
Comment on lines
+105
to
+110
| @contextmanager | ||
| def error_check(error_message: str) -> None: | ||
| try: | ||
| yield | ||
| except Exception as error: | ||
| raise can.CanOperationError(error_message) from error |
Collaborator
Author
There was a problem hiding this comment.
Thank's Brian for the chunk of reviews!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1046.